Page MenuHomeFreeBSD

Include USB mouse driver
Needs ReviewPublic

Authored by br on Aug 30 2022, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 12:00 AM
Unknown Object (File)
Nov 7 2023, 2:56 AM
Unknown Object (File)
Oct 6 2023, 1:54 AM
Unknown Object (File)
Jun 20 2023, 4:06 PM
Unknown Object (File)
Mar 16 2023, 7:09 PM
Unknown Object (File)
Feb 17 2023, 4:22 PM
Unknown Object (File)
Feb 11 2023, 7:19 PM
Unknown Object (File)
Jan 10 2023, 3:04 AM

Details

Reviewers
manu
Group Reviewers
arm64
Summary

Include USB mouse driver to GENERIC.

Obtained from: CheriBSD.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Aug 30 2022, 11:52 AM

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

In D36394#826540, @br wrote:

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

Because you didn't recompiled the modules perhaps ?
This is expected on current for any modules.
I don't see why we should include ums in GENERIC, we already have too much stuff.

In D36394#826604, @manu wrote:
In D36394#826540, @br wrote:

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

Because you didn't recompiled the modules perhaps ?
This is expected on current for any modules.
I don't see why we should include ums in GENERIC, we already have too much stuff.

I believe USB mouse is part of basic functionality of USB stack and g, same as USB keyboard.

In D36394#826604, @manu wrote:
In D36394#826540, @br wrote:

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

Because you didn't recompiled the modules perhaps ?
This is expected on current for any modules.
I don't see why we should include ums in GENERIC, we already have too much stuff.

That is the point, if you mess with different ABIs, developing stuff (e.g. have multiple rootfs'es, multiple kernels) you still expect a basic functionality from the kernel. Since USB stack is already included, USB keyboard already included, then USB mouse should also be there.

I was under the impression from what you'd said it was in amd64's GENERIC but not arm64's, but that's not the case. It seems a little odd to care about a single-file USB driver that most people using their computer as a proper computer rather than a development board will want, but if it's loaded as a module on amd64 then it should be too on arm64 (or compiled in for both). It was not at all clear your problem was that you were missing modules / had incompatible ones, it sounded like your problem was that ums really needed to be in the kernel.

In D36394#826670, @br wrote:
In D36394#826604, @manu wrote:
In D36394#826540, @br wrote:

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

Because you didn't recompiled the modules perhaps ?
This is expected on current for any modules.
I don't see why we should include ums in GENERIC, we already have too much stuff.

I believe USB mouse is part of basic functionality of USB stack and g, same as USB keyboard.

keyboards are useful to login and do stuff, mouse isn't.

In D36394#826604, @manu wrote:
In D36394#826540, @br wrote:

We don't have ums on amd64 either

I don't have any objection but it should be loaded automatically when a USB mouse is found?

My situation was that I have updated kernel, then noticed mouse is not working anymore.
I spent a day looking for a bug in DRM and purecap user graphical stack. Eventually found that my kernel driver module for mouse is not compatible with new kernel.

Because you didn't recompiled the modules perhaps ?
This is expected on current for any modules.
I don't see why we should include ums in GENERIC, we already have too much stuff.

That is the point, if you mess with different ABIs, developing stuff (e.g. have multiple rootfs'es, multiple kernels) you still expect a basic functionality from the kernel. Since USB stack is already included, USB keyboard already included, then USB mouse should also be there.