hda: add patch for Framework laptop v2 headphone jack
ClosedPublic
Actions

Authored by timp87_gmail.com on Aug 26 2022, 2:17 AM.

Details

Reviewers

Commits

rG04c146afea26: hda: add patch for Framework laptop v2 headphone jack
rGd88dc1b0b9af: hda: add patch for Framework laptop v2 headphone jack

Summary

Framework computers company has recently released new generation of their laptop.
Previously it was based on Intel Gen11th CPU. Now it's on Intel Gen12th CPU.

I got a Framework laptop v2 (Gen12th CPU) from Batch 2.
Sound didn't switch to headphones when connected. Fix it.

Add new laptop support the same way it was done in D34596
Add subvendor ID to existing FRAMEWORK_LAPTOP define
Provide better user experience by default by enabling correct mic switch if headphones inserted.

Put the mic on external jack (nid11) and the embedded mic in one association.
I think this completes D34596, because with D34596 commit there are two pcm devices: one with internal mic and the other with headphones and sound output.
So you had to reconfigure sound input in the apps (for example, browser) to the second pcm (pcm1) device to use laptop's mic. Possible only in firefox as chromium uses only one default pcm unit without any ability to re-set it. Once headphones with mic connected sound input and output switches to the first pcm (pcm0).
With this addition you'll have just one pcm device where both input and output switches correctly once headphones connected/disconnected.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

timp87_gmail.com created this revision.Aug 26 2022, 2:17 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 26 2022, 2:17 AM

timp87_gmail.com requested review of this revision.Aug 26 2022, 2:17 AM

timp87_gmail.com edited the summary of this revision. (Show Details)Aug 26 2022, 2:31 AM

timp87_gmail.com edited the summary of this revision. (Show Details)Aug 26 2022, 6:37 PM

timp87_gmail.com edited the summary of this revision. (Show Details)

Thanks for this - I will shepherd this in shortly.

For future reference when creating reviews via the web interface please add full context to your diffs via e.g. git show -U999999 <hash> or git diff -U999999 as it makes it easier for reviewers to see the surrounding context. (No need to refresh this review as this change is quite self contained.)

Can you confirm author info should be "Pavel Timofeev" <timp87@gmail.com>

emaste added inline comments.Aug 28 2022, 11:30 PM

sys/dev/sound/pci/hda/hdac.h
509	I wonder if these have any other / official names, maybe `FRAMEWORK_LAPTOP_11TH_GEN_SUBVENDOR` and `FRAMEWORK_LAPTOP_12TH_GEN_SUBVENDOR`? But current names are fine if not.

emaste added inline comments.Aug 28 2022, 11:35 PM

sys/dev/sound/pci/hda/hdaa_patches.c
332	this line is overly long and needs to be wrapped - I will take care of it on submit

In D36354#826243, @emaste wrote:

Thanks for this - I will shepherd this in shortly.

For future reference when creating reviews via the web interface please add full context to your diffs via e.g. git show -U999999 <hash> or git diff -U999999 as it makes it easier for reviewers to see the surrounding context. (No need to refresh this review as this change is quite self contained.)

Can you confirm author info should be "Pavel Timofeev" <timp87@gmail.com>

Ok, sorry about that.
Yes, this author info is correct.

timp87_gmail.com added inline comments.Aug 29 2022, 2:11 AM

sys/dev/sound/pci/hda/hdac.h
509	Well, I could not find any official names. They actually don't use anything except CPU when referencing laptop generations. So your suggestion might be even better then mine with device id.