Differential D36024

linuxkpi: pm: Add more defines and includes
ClosedPublic
Actions

Authored by manu on Aug 2 2022, 3:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 3, 11:54 PM

	Unknown Object (File)
	Jan 23 2024, 3:28 AM

	Unknown Object (File)
	Dec 20 2023, 1:37 AM

	Unknown Object (File)
	Dec 12 2023, 12:32 PM

	Unknown Object (File)
	Aug 10 2023, 8:41 PM

	Unknown Object (File)
	Aug 8 2023, 11:42 AM

	Unknown Object (File)
	Aug 8 2023, 11:42 AM

	Unknown Object (File)
	Aug 8 2023, 10:53 AM

View All 11 Files

Subscribers

Details

Reviewers

emaste
• hselasky

Commits

rGb296b4574eb3: linuxkpi: pm: Add more defines and includes
rG2ff0f051498a: linuxkpi: pm: Add more defines and includes

Summary

Needed by drm-kmod.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Aug 2 2022, 3:32 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 2 2022, 3:32 PM

manu requested review of this revision.Aug 2 2022, 3:32 PM

Harbormaster completed remote builds in B46726: Diff 108821.Aug 2 2022, 3:33 PM

manu added a parent revision: D36023: linuxkpi: Include highmem.h in pagemap.h.Aug 2 2022, 3:33 PM

manu added a child revision: D36025: linuxkpi: Include linux/file.h in linux/shmem_fs.h.

emaste accepted this revision.Aug 2 2022, 4:11 PM

This revision is now accepted and ready to land.Aug 2 2022, 4:11 PM

emaste added inline comments.Aug 2 2022, 4:12 PM

sys/compat/linuxkpi/common/include/linux/pm.h
44–45	curious - do we actually need an empty struct?

manu added inline comments.Aug 2 2022, 4:18 PM

sys/compat/linuxkpi/common/include/linux/pm.h
37	drm needs this but linux_usb.c doesn't like it ... Will probably remove this and patch drm.
44–45	It's used in some struct for amdgpu and radeon, even if it's not used after (it's not guarded correctly upstream iirc)

bz added a subscriber: bz.Aug 2 2022, 4:19 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/pm.h
44–45	Yes. Often. Sounds weird, is weird, but also avoids changing upstream code. I'd rather have the empty struct (often filled a bit over time), than start changing imported code.

bz added inline comments.Aug 2 2022, 4:22 PM

sys/compat/linuxkpi/common/include/linux/pm.h
37	I have more of things linux_usb.c in LinuxKPI doesn't like. I hope to detangle linux_usb.c from out base USB some more the next months as I need a LinuxKPI struct device there as well. If you decide to change drm, make a note so we can "fix" it later, as in leve the #include #if 0 with a comment or similar please.

emaste added inline comments.Aug 2 2022, 4:26 PM

sys/compat/linuxkpi/common/include/linux/pm.h
44–45	got it

• hselasky accepted this revision.Aug 4 2022, 1:09 PM

Closed by commit rG2ff0f051498a: linuxkpi: pm: Add more defines and includes (authored by manu). · Explain WhyAug 8 2022, 2:07 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG2ff0f051498a: linuxkpi: pm: Add more defines and includes.

manu added a commit: rGb296b4574eb3: linuxkpi: pm: Add more defines and includes.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

10 lines

Diff 109002

sys/compat/linuxkpi/common/include/linux/pm.h

Loading...