Page MenuHomeFreeBSD

linuxkpi: pm: Add more defines and includes
ClosedPublic

Authored by manu on Tue, Aug 2, 3:32 PM.

Details

Summary

Needed by drm-kmod.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.Tue, Aug 2, 3:32 PM
This revision is now accepted and ready to land.Tue, Aug 2, 4:11 PM
sys/compat/linuxkpi/common/include/linux/pm.h
43–44

curious - do we actually need an empty struct?

sys/compat/linuxkpi/common/include/linux/pm.h
36

drm needs this but linux_usb.c doesn't like it ...
Will probably remove this and patch drm.

43–44

It's used in some struct for amdgpu and radeon, even if it's not used after (it's not guarded correctly upstream iirc)

bz added inline comments.
sys/compat/linuxkpi/common/include/linux/pm.h
43–44

Yes. Often. Sounds weird, is weird, but also avoids changing upstream code. I'd rather have the empty struct (often filled a bit over time), than start changing imported code.

sys/compat/linuxkpi/common/include/linux/pm.h
36

I have more of things linux_usb.c in LinuxKPI doesn't like. I hope to detangle linux_usb.c from out base USB some more the next months as I need a LinuxKPI struct device there as well.
If you decide to change drm, make a note so we can "fix" it later, as in leve the #include #if 0 with a comment or similar please.

sys/compat/linuxkpi/common/include/linux/pm.h
43–44

got it

This revision was automatically updated to reflect the committed changes.