Page MenuHomeFreeBSD

Series of small net80211 commits, mostly for VHT
ClosedPublic

Authored by bz on Fri, Jul 29, 12:24 AM.

Details

Summary

net80211: radiotap: add one more define for HE

Add one more define for HE radiotap used by a driver.

MFC after: 1 week

net80211: add more 802.11ac Element IDs

Add more Element IDs for VHT (11ac) to complete the current list
and we can use them if/as needed.

Sposnored by: The FreeBSD Foundation
MFC after: 1 week

net80211: correct IEEE80211_FEXT_BITS

Correct IEEE80211_FEXT_BITS adding the missed one and move the later
one further. This will actually make VHT to show.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

net80211: improve DDB output.

Start adding more fields to DDB output related to VHT (11ac) and
mark COM, VAP, and STA more explicitly to make show all vaps /..
more readable.

Sponsored by: The FreeBSD Foundaton
MFC after: 1 week

net80211: add VHT5G and VHT2G checks/return to media_status

Add the fields for VHT (2Ghz and 5Ghz) to report back by media_status
so we actually have a chance to get the right information.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

net80211: VHT correct check/option in ieee80211_vht_adjust_channel()

In ieee80211_vht_adjust_channel() we have to check for all possible
IEEE80211_FVHT_VHT* options using the mask rather than just checking
for IEEE80211_FVHT_VHT; ieee80211_vhtchanflags() (contrary to its
HT counterpart) only returns the "highest" flag nor or-ing them together
with the base flag. For the moment this seems to make sense as with
more width options we'd add a pyramid.

Later on, in the same function when we get VHT160 actually go and look
for VHT160 and not VHT80.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

net80211: change order in ieee80211_vhtchanflags()

While 80P80 is less likely to be used, VHT160 (a single contiguous
width) is harder to acquire but also preferable so return that first.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz requested review of this revision.Fri, Jul 29, 12:24 AM
bz retitled this revision from Series of small net80211 commits, mostly for VHT net80211: radiotap: add one more define for HE to Series of small net80211 commits, mostly for VHT.Fri, Jul 29, 12:25 AM
bz edited the summary of this revision. (Show Details)

Do you have this series available in a public repo?

Do you have this series available in a public repo?

No; you can fairly easily match them up though; I had them lined up to push until it occurred to me that cy@ and maybe @adrian might still be interested in having a look pre-commit. I hadn't thought of what arc would do with a series of commits. Would it help if I make these 7 small reviews and mark them related in Phabricator?

Would it help if I make these 7 small reviews and mark them related in Phabricator?

These are all pretty small, I don't think it's worth the effort.

sys/net80211/ieee80211_vht.c
822 ↗(On Diff #108681)

is this comment outdated?

bz marked an inline comment as done.

Remove for(;;)-stale comment.

sys/net80211/ieee80211_vht.c
822 ↗(On Diff #108681)

Yeah, probably from day one this file was committed?

sys/net80211/ieee80211_vht.c
822 ↗(On Diff #108681)

I don't THINK it was outdated; the logic was to start by a VHT80 lookup, and since the rest of the channel lookups only happen if c == NULL. I left that there so we could just keep adding new channel lookups above it.

I forget when VHT160/80p80 came in.

This revision is now accepted and ready to land.Fri, Jul 29, 1:41 AM