tcp rack: cleanup code and fix minor issue
ClosedPublic
Actions

Authored by tuexen on Jul 19 2022, 7:48 PM.

Details

Reviewers

rrs
rscheff

Group Reviewers

transport

Commits

rGf450156bea76: tcp rack: simplify computation of rsm start and end
rG1abc27dd52e5: tcp rack: simplify computation of rsm start and end

Summary

This patch simplifies the computation of the rsm->start and rsm->end. It also fixes a minor bug where the RACK_HAS_SYN flag is set incorrectly, if snd_una has wrapped around and matches again iss.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jul 19 2022, 7:48 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 19 2022, 7:48 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jul 19 2022, 7:48 PM

rrs accepted this revision.Aug 1 2022, 6:25 PM

This revision is now accepted and ready to land.Aug 1 2022, 6:25 PM

Closed by commit rG1abc27dd52e5: tcp rack: simplify computation of rsm start and end (authored by tuexen). · Explain WhyAug 2 2022, 10:50 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG1abc27dd52e5: tcp rack: simplify computation of rsm start and end.

tuexen added a commit: rGf450156bea76: tcp rack: simplify computation of rsm start and end.Feb 1 2023, 11:31 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

11 lines

Diff 108802

View Options

sys/netinet/tcp_stacks/rack.c

tcp rack: cleanup code and fix minor issueClosedPublicActions