Fix ofw pcib when it rman_init fails
ClosedPublic
Actions

Authored by andrew on Jun 30 2022, 6:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 30, 1:37 AM

	Unknown Object (File)
	Thu, Apr 30, 1:37 AM

	Unknown Object (File)
	Tue, Apr 28, 2:02 PM

	Unknown Object (File)
	Tue, Apr 28, 1:46 PM

	Unknown Object (File)
	Tue, Apr 28, 4:26 AM

	Unknown Object (File)
	Fri, Apr 24, 6:04 PM

	Unknown Object (File)
	Wed, Apr 15, 8:22 AM

	Unknown Object (File)
	Wed, Apr 15, 2:08 AM

View All Files

Subscribers

imp

Details

Reviewers

bz
imp

Group Reviewers

ARM
arm64

Commits

rGb1e931327426: Fix ofw pcib when it rman_init fails

Summary

rman_fini assumes rman_init has been called successfully. Clean up
init faulure by only calling rman_fini when rman_init has succeeded.

While here add ofw_pcib_fini that can be used by a sub-class to clean
up.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 30 2022, 6:28 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 30 2022, 6:28 PM

andrew requested review of this revision.Jun 30 2022, 6:28 PM

Harbormaster completed remote builds in B46213: Diff 107621.Jun 30 2022, 6:28 PM

andrew added a child revision: D35682: Add Rockchip PCIe cleanup on attach faulure.Jun 30 2022, 6:29 PM

LGTM

This revision is now accepted and ready to land.Jun 30 2022, 7:01 PM

imp accepted this revision.Jun 30 2022, 7:50 PM

Closed by commit rGb1e931327426: Fix ofw pcib when it rman_init fails (authored by andrew). · Explain WhyJul 4 2022, 2:27 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGb1e931327426: Fix ofw pcib when it rman_init fails.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ofw/

ofw_pcib.c

28 lines

ofwpci.h

1 line

Diff 107734

View Options

sys/dev/ofw/ofw_pcib.c