pf: reduce the risk of src/dst mis-use
ClosedPublic
Actions

Authored by kp on Jun 23 2022, 9:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 9, 5:57 AM

	Unknown Object (File)
	Wed, Jul 8, 2:52 PM

	Unknown Object (File)
	Mon, Jun 22, 4:22 PM

	Unknown Object (File)
	Thu, Jun 18, 8:43 AM

	Unknown Object (File)
	Jun 8 2026, 4:36 PM

	Unknown Object (File)
	May 3 2026, 9:33 AM

	Unknown Object (File)
	May 1 2026, 2:20 PM

	Unknown Object (File)
	May 1 2026, 12:16 PM

Subscribers

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG8e1c23341c0c: pf: reduce the risk of src/dst mis-use

Summary

NULL out src/dst and check them rather than relying of 'af' to indicate
these variables are valid.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jun 23 2022, 9:19 AM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJun 23 2022, 9:19 AM

kp requested review of this revision.Jun 23 2022, 9:19 AM

Harbormaster completed remote builds in B46089: Diff 107287.Jun 23 2022, 9:19 AM

kp mentioned this in D35551: pf: copy out rather than m_pullup() in pf_test_eth_rule().Jun 23 2022, 9:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 28 2022, 12:02 PM

Closed by commit rG8e1c23341c0c: pf: reduce the risk of src/dst mis-use (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG8e1c23341c0c: pf: reduce the risk of src/dst mis-use.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

6 lines

Diff 107473

View Options

pf: reduce the risk of src/dst mis-useClosedPublicActions