netinet6: simplify defrouter_select_fib()
ClosedPublic
Actions

Authored by melifaro on Jun 19 2022, 7:14 PM.

Details

Reviewers

Group Reviewers

network

Commits

rG4907fce612c0: netinet6: simplify defrouter_select_fib()
rG9d16275c65bf: netinet6: simplify defrouter_select_fib()

Summary

Simplify defrouter_select_fib():

factor out underlying llenty check into a separate function and use it consistently
join epoch once instead of multiple in/out jumps
don't execute body when RT_ALL_FIBS supplied

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46030
Build 42919: arc lint + arc unit

Event Timeline

melifaro created this revision.Jun 19 2022, 7:14 PM

Herald added subscribers: glebius, bz, ae, imp. · View Herald TranscriptJun 19 2022, 7:14 PM

melifaro requested review of this revision.Jun 19 2022, 7:14 PM

Harbormaster completed remote builds in B46030: Diff 107165.Jun 19 2022, 7:14 PM

melifaro edited the summary of this revision. (Show Details)Jun 19 2022, 7:18 PM

melifaro added reviewers: network, bz.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2022, 12:45 PM

Closed by commit rG9d16275c65bf: netinet6: simplify defrouter_select_fib() (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG9d16275c65bf: netinet6: simplify defrouter_select_fib().

melifaro added a commit: rG4907fce612c0: netinet6: simplify defrouter_select_fib().Jan 13 2023, 9:32 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

nd6_rtr.c

51 lines

Diff 107165

View Options

netinet6: simplify defrouter_select_fib()ClosedPublicActions