For now it only supports making disks blinking:
Usage:
sesutil locate disk [on|off]
a special argument 'all' can be used for disks.
Details
Details
- Reviewers
mav - Group Reviewers
manpages - Commits
- rS287473: Add a new sesutil(8) utility
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| usr.sbin/sesutil/sesutil.8 | ||
|---|---|---|
| 44 ↗ | (On Diff #8392) | "locate" implies that the command searches for a drive. Maybe "indicator" or "identify" or something? Or even just "LED" or "led"? |
| 45 ↗ | (On Diff #8392) | s/Cange/Change/ |
| 48 ↗ | (On Diff #8392) | The device name of the disk, like .Cm da12 , or .Cm all to indicate all disks. But that last part is wrong, I think. Is it all disks attached to SES controllers? All disks that support SES commands? |
| 54 ↗ | (On Diff #8392) | s/LED/LEDs/ |
| 58 ↗ | (On Diff #8392) | Turn on the external LED of drive .Pa da15 : |
| 66 ↗ | (On Diff #8392) | s/appearred/appeared/ |
| usr.sbin/sesutil/sesutil.8 | ||
|---|---|---|
| 44 ↗ | (On Diff #8392) | locate is the usual command for this, the goal is to locate the disk :), mfiutil for example uses the same name. the other name commonly used is "ident" |
| usr.sbin/sesutil/sesutil.c | ||
|---|---|---|
| 58 ↗ | (On Diff #8395) | Could we change from 'unsigned int' to 'int' and avoid the -Werror,-Wsign-compare? |
| 82 ↗ | (On Diff #8395) | The variable *obj seems to be not used here. Could we remove it and avoid -Wunused-variable? |
| 84 ↗ | (On Diff #8395) | The same for 'o'. |
| 161 ↗ | (On Diff #8395) | Here is just for style than anything else, as you are initializing the variable i inside the loop, it could be 'int i;' like in some other functions. But it really doesn't matter, only for code consistency. |
Comment Actions
- I think device name comparison won't work right, giving either false positives or negatives..
- If some enclosure was disconnected, ses device names may not be consequential. In such case your code won't find ones after the hole.
- I don't remember specific bits, but I have feeling that just writing zero to element control may cause unwanted effects.