tcp: skip sackhole checks on NULL
ClosedPublic
Actions

Authored by rscheff on Jun 7 2022, 6:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 7:38 AM

	Unknown Object (File)
	Sat, Apr 27, 7:37 AM

	Unknown Object (File)
	Sat, Apr 27, 7:37 AM

	Unknown Object (File)
	Sat, Apr 27, 6:04 AM

	Unknown Object (File)
	Fri, Apr 26, 5:54 AM

	Unknown Object (File)
	Feb 16 2024, 1:05 PM

	Unknown Object (File)
	Jan 14 2024, 4:39 PM

	Unknown Object (File)
	Dec 23 2023, 12:25 AM

View All 32 Files

Subscribers

imp

melifaro

Details

Reviewers

tuexen
• hselasky
glebius

Group Reviewers

transport

Commits

rG231e0dd5d1fb: tcp: skip sackhole checks on NULL

Summary

Inadvertedly introduced NULL pointer dereference during
sackhole sanity check in D35387.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Jun 7 2022, 6:20 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 7 2022, 6:20 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jun 7 2022, 6:20 PM

Harbormaster completed remote builds in B45897: Diff 106736.Jun 7 2022, 6:20 PM

I think such trivial fixes should be just committed ASAP, not waiting for a review.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 7 2022, 6:47 PM

Closed by commit rG231e0dd5d1fb: tcp: skip sackhole checks on NULL (authored by rscheff). · Explain Why

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG231e0dd5d1fb: tcp: skip sackhole checks on NULL.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_sack.c

4 lines

Diff 106737

View Options

tcp: skip sackhole checks on NULLClosedPublicActions