Page MenuHomeFreeBSD
Differential D35423

tcp: skip sackhole checks on NULL
ClosedPublic
Actions

Authored by rscheff on Jun 7 2022, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 5:17 PM
Unknown Object (File)
Tue, Aug 11, 11:40 PM
Unknown Object (File)
Tue, Aug 11, 6:25 AM
Unknown Object (File)
Sun, Aug 9, 11:07 AM
Unknown Object (File)
Sat, Aug 8, 1:33 AM
Unknown Object (File)
Mon, Jul 27, 2:02 AM
Unknown Object (File)
Jun 24 2026, 4:59 AM
Unknown Object (File)
May 22 2026, 6:03 PM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
tuexen
• hselasky
glebius
Group Reviewers
transport
Commits
rG231e0dd5d1fb: tcp: skip sackhole checks on NULL
Summary

Inadvertedly introduced NULL pointer dereference during
sackhole sanity check in D35387.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff created this revision.Jun 7 2022, 6:20 PM
Herald added a reviewer: transport. · View Herald TranscriptJun 7 2022, 6:20 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Jun 7 2022, 6:20 PM
Harbormaster completed remote builds in B45897: Diff 106736.Jun 7 2022, 6:20 PM
glebius accepted this revision.Jun 7 2022, 6:27 PM

I think such trivial fixes should be just committed ASAP, not waiting for a review.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 7 2022, 6:47 PM
Closed by commit rG231e0dd5d1fb: tcp: skip sackhole checks on NULL (authored by rscheff). · Explain Why
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG231e0dd5d1fb: tcp: skip sackhole checks on NULL.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines

Diff 106737

View Options

sys/netinet/tcp_sack.c

Loading...