Page MenuHomeFreeBSD

pmcannotate: Add a '-m' mode option to control per-line annotations.
AcceptedPublic

Authored by jhb on Jun 3 2022, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 7:21 AM
Unknown Object (File)
Thu, Apr 11, 12:24 PM
Unknown Object (File)
Jan 15 2024, 7:11 PM
Unknown Object (File)
Dec 20 2023, 5:59 AM
Unknown Object (File)
Dec 15 2023, 4:36 AM
Unknown Object (File)
Dec 10 2023, 3:36 PM
Unknown Object (File)
Nov 17 2023, 2:51 PM
Unknown Object (File)
Nov 17 2023, 12:07 PM

Details

Reviewers
mav
pauamma_gundo.com
Group Reviewers
manpages
Summary
  • "block" (the default mode) displays per-block percentages in front of each annotated line.
  • "global" displays a global percentage in front of each line.
  • "raw" displays the raw count of sample hits in front of each line.

Sponsored by: University of Cambridge, Google, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45884
Build 42772: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jun 3 2022, 10:04 PM

I have no objections, but I am fine with the current format. Global percents from the whole kernel would be a pretty small number. Raw number may be pretty big for a hot part of a small program. But whatever...

This revision is now accepted and ready to land.Jun 4 2022, 1:11 AM
pauamma_gundo.com added inline comments.
usr.sbin/pmcannotate/pmcannotate.8
90–100

What I think this means, after staring at it for a bit, is (using example numbers of 4 samples in a given line, 20 samples in the block - however defined - that line is in, and 80 samples altogether:

  • raw would display: 4
  • block would display; 20%
  • global would display: 1.25%

Is that what you mean?

usr.sbin/pmcannotate/pmcannotate.8
90–100
  • global would display: 1.25%

5%, not 1.25%.

usr.sbin/pmcannotate/pmcannotate.8
90–100

Yes, that is what it means.

pauamma_gundo.com added inline comments.
usr.sbin/pmcannotate/pmcannotate.8
90–100

Thanks for confirming.

95–98

Suggestion for clarity.

This revision now requires changes to proceed.Jun 5 2022, 1:11 AM
jhb marked an inline comment as done.Jun 6 2022, 11:55 PM
bcr added a subscriber: bcr.

OK from manpages.

This revision is now accepted and ready to land.Oct 13 2022, 4:45 PM