Page MenuHomeFreeBSD

hwpmc: Permit the minimum sampling count to be set as a sysctl.
ClosedPublic

Authored by jhb on Jun 3 2022, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 5:04 PM
Unknown Object (File)
Sun, Mar 23, 9:38 PM
Unknown Object (File)
Sat, Mar 8, 10:59 AM
Unknown Object (File)
Mar 7 2025, 3:16 PM
Unknown Object (File)
Mar 7 2025, 1:52 AM
Unknown Object (File)
Feb 23 2025, 7:47 PM
Unknown Object (File)
Feb 10 2025, 11:44 AM
Unknown Object (File)
Feb 10 2025, 11:41 AM

Details

Summary

A rarely occurring event (e.g. an event that occurs less than 1000
times during execution of a program) may require a lower minimum
threshold than 1000. Replace the hardcoded 1000 with a sysctl that
the administrator can use to permit smaller sampling count values.

Sponsored by: University of Cambridge, Google, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 3 2022, 10:02 PM

I agree that the hard coded limitation is annoying. I hurt me also when I've tried to profile something with PCM_SOFT and low event rate. It is good to have it at least configurable.

This revision is now accepted and ready to land.Jun 4 2022, 12:49 AM

Please add this to the sysctl section in hwpmc(4).

This revision now requires review to proceed.Jun 6 2022, 11:51 PM
This revision is now accepted and ready to land.Jun 9 2022, 12:56 PM
pauamma_gundo.com added inline comments.
share/man/man4/hwpmc.4
420

Clearer and more consistent with change log message.