Page MenuHomeFreeBSD
Differential D35353

libsysdecode: For future use extract common code to a separate files
ClosedPublic
Actions

Authored by dchagin on May 30 2022, 5:08 PM.
Tags
None
Referenced Files
F153378198: D35353.id107229.diff
Mon, Apr 20, 7:40 PM
F153238210: D35353.diff
Mon, Apr 20, 12:13 AM
Unknown Object (File)
Wed, Apr 15, 11:57 PM
Unknown Object (File)
Sun, Apr 5, 1:00 AM
Unknown Object (File)
Sat, Apr 4, 9:28 PM
Unknown Object (File)
Sat, Apr 4, 4:37 PM
Unknown Object (File)
Thu, Apr 2, 10:25 PM
Unknown Object (File)
Wed, Mar 25, 11:35 PM
View All Files
Subscribers
imp

Details

Reviewers
jhb
emaste
markj
Commits
rGaa54b10f0570: libsysdecode: For future use extract common code to a separate files
rG9dac609629d4: libsysdecode: For future use extract common code to a separate files

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.May 30 2022, 5:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 30 2022, 5:08 PM
dchagin requested review of this revision.May 30 2022, 5:08 PM
Harbormaster completed remote builds in B45768: Diff 106477.May 30 2022, 5:08 PM
dchagin mentioned this in D35209: libsysdecode: Using ${SRCTOP}/sys to generate tables.h.May 30 2022, 5:21 PM
dchagin mentioned this in D35214: libsysdecode: Add linux_gen_table to mktables for future use.
dchagin added a child revision: D35215: libsysdecode: Add method for decoding linux signal names.May 30 2022, 5:24 PM
dchagin added reviewers: jhb, emaste, markj.May 30 2022, 5:28 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin added a child revision: D35354: libsysdecode: Add preliminary support for decoding Linux syscalls.
emaste added a comment.May 30 2022, 5:30 PM

I think this is fine but will defer to @jhb.

jhb accepted this revision.May 31 2022, 4:29 PM
jhb added inline comments.
lib/libsysdecode/support.h
56

normal style would put a tab after the types here in prototypes FWIW, but not for 'const char *' as it is too long.

This revision is now accepted and ready to land.May 31 2022, 4:29 PM
emaste accepted this revision.May 31 2022, 5:28 PM
Closed by commit rG9dac609629d4: libsysdecode: For future use extract common code to a separate files (authored by dchagin). · Explain WhyJun 22 2022, 11:41 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG9dac609629d4: libsysdecode: For future use extract common code to a separate files.
dchagin added a commit: rGaa54b10f0570: libsysdecode: For future use extract common code to a separate files.Jul 6 2022, 11:05 AM

Revision Contents
Changeset List

PathSize
lib/
libsysdecode/
2 lines
159 lines
62 lines
168 lines

Diff 107229

View Options

lib/libsysdecode/Makefile

Loading...
View Options

lib/libsysdecode/flags.c

Loading...
View Options

lib/libsysdecode/support.h

Loading...
View Options

lib/libsysdecode/support.c

Loading...