Page MenuHomeFreeBSD

libsysdecode: Using ${SRCTOP}/sys to generate tables.h
Needs ReviewPublic

Authored by dchagin on Sat, May 14, 4:58 PM.

Details

Reviewers
jhb
emaste
Summary

To generate tables.h use headers under $DESTDIR but libsysdecode builds
using headers under $SRCTOP dir. Changing header file under $SRCTOP can
leads to break libsysdecode build, e.g., removimg defines which is used
in tables.h.
Also we does not install compat/linux headers to the $DESTDIR that
prevents to decode Linuxulator's syscalls.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 45582
Build 42470: arc lint + arc unit

Event Timeline

finished, tested on arm64 (sysarch), amd64

Summary changed:

To generate tables.h headers under $DESTDIR are used but libsysdecode uses mixed headers to build.
The difference between the same header located in the $DESTDIR and in the $SRC can cause the libsysdecode to fail to build.
Also we does not install compat/linux headers, that prevents us to decode Linuxulator's syscalls.

Add -I${SRCTOP}/lib/libsysdecode to CFLAGS