libsysdecode: Using ${SRCTOP}/sys to generate tables.h
Needs ReviewPublic
Actions

Authored by dchagin on Sat, May 14, 4:58 PM.

Details

Reviewers

jhb
emaste

Summary

To generate tables.h use headers under $DESTDIR but libsysdecode builds
using headers under $SRCTOP dir. Changing header file under $SRCTOP can
leads to break libsysdecode build, e.g., removimg defines which is used
in tables.h.
Also we does not install compat/linux headers to the $DESTDIR that
prevents to decode Linuxulator's syscalls.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 45582
Build 42470: arc lint + arc unit

Event Timeline

dchagin created this revision.Sat, May 14, 4:58 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, May 14, 4:58 PM

dchagin requested review of this revision.Sat, May 14, 4:58 PM

Harbormaster completed remote builds in B45579: Diff 106001.Sat, May 14, 4:58 PM

dchagin added reviewers: jhb, emaste.Sat, May 14, 5:00 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.

finished, tested on arm64 (sysarch), amd64

Harbormaster completed remote builds in B45580: Diff 106006.Sun, May 15, 9:12 AM

Summary changed:

To generate tables.h headers under $DESTDIR are used but libsysdecode uses mixed headers to build.
The difference between the same header located in the $DESTDIR and in the $SRC can cause the libsysdecode to fail to build.
Also we does not install compat/linux headers, that prevents us to decode Linuxulator's syscalls.