Differential D35334

sockbuf: remove unused mbuf counter and cluster counter
ClosedPublic
Actions

Authored by glebius on May 27 2022, 4:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 17, 1:05 AM

	Unknown Object (File)
	Mon, Oct 13, 1:55 AM

	Unknown Object (File)
	Sep 19 2025, 4:02 PM

	Unknown Object (File)
	Sep 16 2025, 2:02 AM

	Unknown Object (File)
	Jul 25 2025, 10:09 AM

	Unknown Object (File)
	Jun 23 2025, 11:39 AM

	Unknown Object (File)
	Jun 17 2025, 1:04 PM

	Unknown Object (File)
	Jun 16 2025, 12:56 PM

View All 69 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

Group Reviewers

Commits

rGd59bc188d652: sockbuf: remove unused mbuf counter and cluster counter

Summary

With M_EXTPG mbufs these two counters already do not represent the
reality. As we are moving towards protocol independent socket buffers,
which may not even use mbufs at all, the counters become less and less
relevant. The only userland seeing them was 'netstat -x'.

PR: 264181 (exp-run)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.May 27 2022, 4:14 AM

Herald added a reviewer: manpages. · View Herald TranscriptMay 27 2022, 4:14 AM

Herald added a subscriber: imp. · View Herald Transcript

glebius requested review of this revision.May 27 2022, 4:14 AM

Harbormaster completed remote builds in B45740: Diff 106413.May 27 2022, 4:14 AM

markj accepted this revision.May 27 2022, 1:18 PM

This revision is now accepted and ready to land.May 27 2022, 1:18 PM

Closed by commit rGd59bc188d652: sockbuf: remove unused mbuf counter and cluster counter (authored by glebius). · Explain WhyMay 27 2022, 3:21 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGd59bc188d652: sockbuf: remove unused mbuf counter and cluster counter.

Manual page change LGTM.

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

31 lines

sys/

2 lines

2 lines

usr.bin/

netstat/

13 lines

9 lines

Diff 106422

sys/kern/uipc_debug.c

Loading...

sys/kern/uipc_sockbuf.c

Loading...

sys/sys/sockbuf.h

Loading...

sys/sys/socketvar.h

Loading...

usr.bin/netstat/inet.c

Loading...

usr.bin/netstat/netstat.1

Loading...