Differential D35334

sockbuf: remove unused mbuf counter and cluster counter
ClosedPublic
Actions

Authored by glebius on May 27 2022, 4:14 AM.

Tags

None

Referenced Files

	F86844519: D35334.id106422.diff
	Wed, Jun 26, 11:26 AM

	Unknown Object (File)
	Tue, Jun 25, 8:31 AM

	Unknown Object (File)
	May 23 2024, 10:59 PM

	Unknown Object (File)
	Apr 9 2024, 2:31 PM

	Unknown Object (File)
	Apr 1 2024, 1:15 PM

	Unknown Object (File)
	Mar 7 2024, 8:27 PM

	Unknown Object (File)
	Jan 15 2024, 9:47 AM

	Unknown Object (File)
	Dec 20 2023, 8:36 AM

View All 30 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

Group Reviewers

Commits

rGd59bc188d652: sockbuf: remove unused mbuf counter and cluster counter

Summary

With M_EXTPG mbufs these two counters already do not represent the
reality. As we are moving towards protocol independent socket buffers,
which may not even use mbufs at all, the counters become less and less
relevant. The only userland seeing them was 'netstat -x'.

PR: 264181 (exp-run)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45740
Build 42628: arc lint + arc unit

Event Timeline

glebius created this revision.May 27 2022, 4:14 AM

Herald added a reviewer: manpages. · View Herald TranscriptMay 27 2022, 4:14 AM

Herald added a subscriber: imp. · View Herald Transcript

glebius requested review of this revision.May 27 2022, 4:14 AM

Harbormaster completed remote builds in B45740: Diff 106413.May 27 2022, 4:14 AM

markj accepted this revision.May 27 2022, 1:18 PM

This revision is now accepted and ready to land.May 27 2022, 1:18 PM

Closed by commit rGd59bc188d652: sockbuf: remove unused mbuf counter and cluster counter (authored by glebius). · Explain WhyMay 27 2022, 3:21 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGd59bc188d652: sockbuf: remove unused mbuf counter and cluster counter.

Manual page change LGTM.

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

31 lines

sys/

2 lines

2 lines

usr.bin/

netstat/

13 lines

7 lines

Diff 106413

sys/kern/uipc_debug.c

Loading...

sys/kern/uipc_sockbuf.c

Loading...

sys/sys/sockbuf.h

Loading...

sys/sys/socketvar.h

Loading...

usr.bin/netstat/inet.c

Loading...

usr.bin/netstat/netstat.1

Loading...