Page MenuHomeFreeBSD
Differential D3530

Add DTrace probe points, translators and a corresponding script to replace the TCPDEBUG functionality with pure DTrace.
ClosedPublic
Actions

Authored by gnn on Aug 29 2015, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 2:03 AM
Unknown Object (File)
Fri, Nov 21, 2:01 AM
Unknown Object (File)
Fri, Nov 21, 2:00 AM
Unknown Object (File)
Fri, Nov 21, 1:59 AM
Unknown Object (File)
Fri, Nov 21, 1:58 AM
Unknown Object (File)
Fri, Nov 21, 1:57 AM
Unknown Object (File)
Fri, Nov 21, 1:57 AM
Unknown Object (File)
Fri, Nov 21, 1:55 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
bz
rwatson
Group Reviewers
network
Commits
rS287759: dd DTrace probe points, translators and a corresponding script

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gnn updated this revision to Diff 8341.Aug 29 2015, 8:07 PM
gnn retitled this revision from to Add DTrace probe points, translators and a corresponding script to replace the TCPDEBUG functionality with pure DTrace..
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptAug 29 2015, 8:07 PM
gnn added reviewers: network, bz, rwatson, markj.Aug 29 2015, 8:08 PM
rwatson edited edge metadata.Aug 30 2015, 3:17 PM

I don't currently have views on the DTrace-related parts themselves, but some quick comments on other details.

cddl/lib/libdtrace/tcp.d
125 ↗(On Diff #8341)

Most of this structure is defined in terms of int32_t and uint32_t -- I realise there was an existing buglet here, but I wonder if we should stop perpetuating that and return to the types used elsewhere in the struct?

183 ↗(On Diff #8341)

Is this just an accidental whitespace change?

sys/netinet/tcp_input.c
108 ↗(On Diff #8341)

Is this change necessary?

gnn updated this revision to Diff 8633.Sep 10 2015, 1:38 AM
gnn marked an inline comment as done.
gnn edited edge metadata.

Updating D3530: Add DTrace probe points, translators and a corresponding script

to replace the TCPDEBUG functionality with pure DTrace.

gnn updated this revision to Diff 8722.Sep 13 2015, 3:01 PM

Update before committing back to svn

Updating D3530: Add DTrace probe points, translators and a corresponding script

to replace the TCPDEBUG functionality with pure DTrace.

gnn updated this revision to Diff 8723.Sep 13 2015, 3:10 PM

Squash the minor changes.

Updating D3530: Add DTrace probe points, translators and a corresponding script

to replace the TCPDEBUG functionality with pure DTrace.

gnn updated this revision to Diff 8724.Sep 13 2015, 3:12 PM

No, really, start in the right place.

Updating D3530: Add DTrace probe points, translators and a corresponding script

to replace the TCPDEBUG functionality with pure DTrace.

Closed by commit rS287759: dd DTrace probe points, translators and a corresponding script (authored by gnn). · Explain WhySep 13 2015, 3:51 PM
This revision was automatically updated to reflect the committed changes.
gnn mentioned this in rS287759: dd DTrace probe points, translators and a corresponding script.

Revision Contents
Changeset List

PathSize
head/
cddl/
lib/
libdtrace/
133 lines
share/
dtrace/
165 lines
sys/
netinet/
10 lines
19 lines
8 lines
1 line
1 line
7 lines
17 lines

Diff 8725

View Options

head/cddl/lib/libdtrace/tcp.d

Loading...
View Options

head/share/dtrace/tcpdebug

Loading...
View Options

head/sys/netinet/in_kdtrace.h

Loading...
View Options

head/sys/netinet/in_kdtrace.c

Loading...
View Options

head/sys/netinet/tcp_input.c

Loading...
View Options

head/sys/netinet/tcp_output.c

Loading...
View Options

head/sys/netinet/tcp_subr.c

Loading...
View Options

head/sys/netinet/tcp_timer.c

Loading...
View Options

head/sys/netinet/tcp_usrreq.c

Loading...