libsa: Fix a bug in nvlist creation
ClosedPublic
Actions

Authored by markj on May 19 2022, 4:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 30, 12:27 PM

	Unknown Object (File)
	Sun, Mar 29, 12:30 AM

	Unknown Object (File)
	Sat, Mar 28, 10:10 AM

	Unknown Object (File)
	Sat, Mar 28, 7:37 AM

	Unknown Object (File)
	Thu, Mar 26, 4:07 PM

	Unknown Object (File)
	Wed, Mar 25, 8:23 PM

	Unknown Object (File)
	Wed, Mar 25, 3:21 PM

	Unknown Object (File)
	Sun, Mar 22, 5:16 AM

View All Files

Subscribers

dab

delphij

Details

Reviewers

tsoome
imp
manu

Commits

rGbcc3148c70c7: libsa: Fix a bug in nvlist creation

Summary

When adding an entry to an nvlist, the data buffer might need to be
resized. When this happens, the XDR encoder's notion of the buffer size
also needs to be updated, otherwise the operation may erroneously fail.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 19 2022, 4:23 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 19 2022, 4:23 PM

Herald added subscribers: dab, delphij. · View Herald Transcript

markj requested review of this revision.May 19 2022, 4:23 PM

Harbormaster completed remote builds in B45631: Diff 106164.May 19 2022, 4:23 PM

markj added a child revision: D35255: libsa: Make the nvlist implementation more self-contained.May 19 2022, 4:23 PM

imp accepted this revision.May 19 2022, 5:09 PM

This revision is now accepted and ready to land.May 19 2022, 5:09 PM

thanks!

Closed by commit rGbcc3148c70c7: libsa: Fix a bug in nvlist creation (authored by markj). · Explain WhyMay 20 2022, 2:37 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbcc3148c70c7: libsa: Fix a bug in nvlist creation.

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

nvlist.c

1 line

Diff 106209

View Options

libsa: Fix a bug in nvlist creationClosedPublicActions