Page MenuHomeFreeBSD

bsdinstall: stop messing with file descriptors
ClosedPublic

Authored by c.koehne_beckhoff.com on Tue, May 3, 5:55 AM.

Details

Summary

Throughout the bsdinstall script fd 3 is used by f_dprintf (set through
$TERMINAL_STDOUT_PASSTHRU). By closing file descriptor 3 here, the
final f_dprintf "Installation Completed ... does not work anymore.

By putting the code into a subshell, file descriptors can be edited
without interference with the calling script.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Tue, May 3, 7:20 AM

This should have a
Fixes 40923b0c81 "Fix scripted installation from media without local distfiles."
I'll do that when commiting.

Hello re@
This breaks scripted install for 13.1
Should this be a candidate for another RC ?

This revision was automatically updated to reflect the committed changes.