Page MenuHomeFreeBSD
Differential D35113

bsdinstall: stop messing with file descriptors
ClosedPublic
Actions

Authored by corvink on May 3 2022, 5:55 AM.
Tags
None
Referenced Files
F81681378: D35113.diff
Fri, Apr 19, 8:53 PM
Unknown Object (File)
Tue, Apr 9, 12:25 AM
Unknown Object (File)
Mon, Apr 8, 10:10 PM
Unknown Object (File)
Mar 13 2024, 2:24 PM
Unknown Object (File)
Feb 4 2024, 10:02 PM
Unknown Object (File)
Dec 27 2023, 3:28 AM
Unknown Object (File)
Dec 23 2023, 11:53 AM
Unknown Object (File)
Dec 2 2023, 6:52 PM
View All 23 Files
Subscribers
grahamperrin
imp

Details

Reviewers
manu
nwhitehorn
emaste
Group Reviewers
releng
Commits
rG45eb93a964e6: bsdinstall: stop messing with file descriptors
rG1f7746d81f53: bsdinstall: stop messing with file descriptors
Summary

Throughout the bsdinstall script fd 3 is used by f_dprintf (set through
$TERMINAL_STDOUT_PASSTHRU). By closing file descriptor 3 here, the
final f_dprintf "Installation Completed ... does not work anymore.

By putting the code into a subshell, file descriptors can be edited
without interference with the calling script.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.May 3 2022, 5:55 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 3 2022, 5:55 AM
corvink requested review of this revision.May 3 2022, 5:55 AM
manu accepted this revision.May 3 2022, 7:20 AM
This revision is now accepted and ready to land.May 3 2022, 7:20 AM
manu added a reviewer: nwhitehorn.May 3 2022, 8:52 AM
manu added a comment.May 3 2022, 9:09 AM

This should have a
Fixes 40923b0c81 "Fix scripted installation from media without local distfiles."
I'll do that when commiting.

manu added a reviewer: releng.May 3 2022, 9:17 AM

Hello re@
This breaks scripted install for 13.1
Should this be a candidate for another RC ?

emaste accepted this revision.May 3 2022, 1:11 PM
Closed by commit rG1f7746d81f53: bsdinstall: stop messing with file descriptors (authored by corvink, committed by manu). · Explain WhyMay 3 2022, 2:06 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG1f7746d81f53: bsdinstall: stop messing with file descriptors.
manu added a commit: rG45eb93a964e6: bsdinstall: stop messing with file descriptors.May 16 2022, 3:27 PM
grahamperrin added a subscriber: grahamperrin.Nov 11 2022, 5:30 AM
In D35113#795883, @manu wrote:

… This breaks scripted install for 13.1 …

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266802#c6 for 1f7746d (2022-10-25):

… should probably be merged into releng/13.1 …

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
13 lines

Diff 105654

View Options

usr.sbin/bsdinstall/scripts/script

Loading...