diff: tests: loosen up requirements for report_identical
ClosedPublic
Actions

Authored by kevans on Apr 18 2022, 9:28 PM.

Details

Reviewers

pstef
bapt
thj

Group Reviewers

Klara

Commits

rGefba49ee5a64: diff: tests: loosen up requirements for report_identical

Summary

This test cannot run without an unprivileged_user being specified
anyways, so just run as the unprivileged user. Revoking read permisions
works just as well if you're guaranteed non-root.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Apr 18 2022, 9:28 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2022, 9:28 PM

kevans requested review of this revision.Apr 18 2022, 9:28 PM

Harbormaster completed remote builds in B45214: Diff 105136.Apr 18 2022, 9:28 PM

I think I'm the one to blame for this, but I've never understood ATF and from other usage across our repo it wasn't clear to me how to properly do this.

This revision is now accepted and ready to land.Apr 18 2022, 9:41 PM

In D34950#792358, @pstef wrote:

I think I'm the one to blame for this, but I've never understood ATF and from other usage across our repo it wasn't clear to me how to properly do this.

No worries. :-) IMO, require.user having valid values of root|unprivileged isn't entirely intuitive.

Closed by commit rGefba49ee5a64: diff: tests: loosen up requirements for report_identical (authored by kevans). · Explain WhyApr 19 2022, 4:05 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGefba49ee5a64: diff: tests: loosen up requirements for report_identical.