Page MenuHomeFreeBSD

diff: tests: loosen up requirements for report_identical
ClosedPublic

Authored by kevans on Apr 18 2022, 9:28 PM.

Details

Summary

This test cannot run without an unprivileged_user being specified
anyways, so just run as the unprivileged user. Revoking read permisions
works just as well if you're guaranteed non-root.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I think I'm the one to blame for this, but I've never understood ATF and from other usage across our repo it wasn't clear to me how to properly do this.

This revision is now accepted and ready to land.Apr 18 2022, 9:41 PM

I think I'm the one to blame for this, but I've never understood ATF and from other usage across our repo it wasn't clear to me how to properly do this.

No worries. :-) IMO, require.user having valid values of root|unprivileged isn't entirely intuitive.