Differential D34929

cxgbei: Return limits for the specific adapter the socket is on.
ClosedPublic
Actions

Authored by jhb on Apr 15 2022, 5:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 13, 7:32 PM

	Unknown Object (File)
	Wed, May 13, 7:32 PM

	Unknown Object (File)
	Wed, May 13, 7:30 PM

	Unknown Object (File)
	Thu, May 7, 10:59 AM

	Unknown Object (File)
	Thu, May 7, 7:47 AM

	Unknown Object (File)
	Mon, May 4, 1:26 PM

	Unknown Object (File)
	Sun, May 3, 6:50 PM

	Unknown Object (File)
	Sun, May 3, 1:33 AM

Subscribers

Details

Reviewers

mav
trasz
np

Commits

rG2c273cf4ceb7: cxgbei: Return limits for the specific adapter the socket is on.
rG43d5661a9d0f: cxgbei: Return limits for the specific adapter the socket is on.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 15 2022, 5:52 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 15 2022, 5:52 PM

jhb requested review of this revision.Apr 15 2022, 5:52 PM

Harbormaster completed remote builds in B45188: Diff 105052.Apr 15 2022, 5:53 PM

jhb added a parent revision: D34928: iscsi: Fetch limits based on a socket rather than assuming global limits..Apr 15 2022, 5:53 PM

mav accepted this revision.Apr 18 2022, 1:43 AM

mav added inline comments.

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
1882	This part looks mostly duplicated from cxgbei_limits().

This revision is now accepted and ready to land.Apr 18 2022, 1:43 AM

jhb added inline comments.Apr 18 2022, 7:50 PM

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
1882	It is, but without the min/max computations. I could perhaps put cxgbei_limits() under #ifdef COMPAT_FREEBSD13 in fact since it should only be used in the compat shim for older binaries.

Closed by commit rG43d5661a9d0f: cxgbei: Return limits for the specific adapter the socket is on. (authored by jhb). · Explain WhyApr 18 2022, 7:54 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG43d5661a9d0f: cxgbei: Return limits for the specific adapter the socket is on..

mav added inline comments.Apr 18 2022, 8:22 PM

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
1882	I don't see a problem from min() in cxgbei_limits(). I was more concerned by it not returning result code, whatever it means. But as you wish...

jhb added a commit: rG2c273cf4ceb7: cxgbei: Return limits for the specific adapter the socket is on..Nov 10 2022, 9:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

cxgbei/

66 lines

Diff 105133

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...