Fix OID format for `vm.swap_reserved` and `vm.swap_total`
ClosedPublic
Actions

Authored by ngie on Apr 11 2022, 12:35 AM.

Details

Reviewers

alc
dougm
kib
markj
cem

Commits

rG567378cc0796: Fix OID format for `vm.swap_reserved` and `vm.swap_total`

Summary

The correct OID format for CTLTYPE_U64 is QU (uquad_t), not A
(text expressed via char *).

This issue was noticed while doing an sysctl tree walk using a
sysctl(9) consumer that relies on the OID format to intuit what the
type should be for a given sysctl.

MFC after: 1 month
Sponsored by: DellEMC Isilon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Apr 11 2022, 12:35 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 11 2022, 12:35 AM

ngie requested review of this revision.Apr 11 2022, 12:35 AM

Harbormaster completed remote builds in B45119: Diff 104856.Apr 11 2022, 12:35 AM

ngie added reviewers: alc, dougm, kib, markj, cem.Apr 11 2022, 12:37 AM

kib accepted this revision.Apr 11 2022, 12:43 AM

This revision is now accepted and ready to land.Apr 11 2022, 12:43 AM

Closed by commit rG567378cc0796: Fix OID format for `vm.swap_reserved` and `vm.swap_total` (authored by ngie). · Explain WhyApr 11 2022, 2:08 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG567378cc0796: Fix OID format for `vm.swap_reserved` and `vm.swap_total`.

Revision Contents
Changeset List

Path

Size

sys/

vm/

swap_pager.c

4 lines

Diff 104861

View Options

Fix OID format for `vm.swap_reserved` and `vm.swap_total`ClosedPublicActions