ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.
ClosedPublic
Actions

Authored by jhb on Apr 7 2022, 6:02 PM.

Details

Reviewers

erj
kgalazka

Commits

rGd32888f4fefa: ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.
rGc0a42a04513d: ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 7 2022, 6:02 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 7 2022, 6:02 PM

jhb requested review of this revision.Apr 7 2022, 6:02 PM

Harbormaster completed remote builds in B45061: Diff 104737.Apr 7 2022, 6:02 PM

As noted in the comments, this isn't really the right fix IMO, but more of a prod to figure out what the right fix is.

I'm going to go with just having all of the cpu_id code be axed. I added @krzysztof.galazka_intel.com to see if he has an opinion, but I can't recall or figure out what the cpu_id code is for. I guess it could've remained from an older version of the iflib api; I vaguely remember some softirq argument change where the cpu_id was removed.

jhb retitled this revision from ix: Mark cpu_id as unused. to ix: Remove cpu_id and related code from ixgbe_if_msix_intr_assign..Apr 12 2022, 10:21 PM

jhb edited the summary of this revision. (Show Details)