Page MenuHomeFreeBSD

spigen(4) SPI Generic IO driver and spibus(4) automatic clock adjustment
Needs ReviewPublic

Authored by on Aug 22 2015, 9:21 PM.


Group Reviewers
Contributor Reviews (base)

Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline retitled this revision from to spigen(4) SPI Generic IO driver and spibus(4) automatic clock adjustment. edited the test plan for this revision. (Show Details) changed the edit policy from "All Users" to "Custom Policy".

Added ioctl variants that include specification of the SPI clock speed to use within the transfer request.

I haven't tested the code yet, but from what I see there is a bug WRT CS handling.

The CS is stored in the child ivar, I believe you are getting the CS set to 0 by a mistake.

The CS must be present in transfer structure (you should not rely on the existence of a kernel driver for the device).

We should probably get rid of the non clocked version of API and make the clocked functions the default API (not setting a clock produce the same result of non clocked version).

[GET|SET]_CLOCK_SPEED should set/get the SPI controller default speed and not the spigen default speed (allowing set the default clock freq for kernel drivers).