ARRAY_SIZE(a) definitions, fix some clang warnings
ClosedPublic
Actions

Authored by avos on Aug 20 2015, 5:07 PM.

Details

Reviewers

• rodrigc
ngie
adrian

Commits

rS287297: - Replace N(a)/N(i)/N(T)/LEN(a)/ARRAY_SIZE(a) with nitems()

Summary

Replace N(a)/N(i)/N(T)/LEN(a)/ARRAY_SIZE(a) with nitems()
Add missing <err.h> for err() and <sys/sysctl.h> for sysctlbyname()
NULL -> 0 for 5th parameter of sysctlbyname()
Fix printf() in tools/tools/ath/ath_ee_v4k_print/v4k.c

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 8090.Aug 20 2015, 5:07 PM

avos retitled this revision from to tools/* : use nitems instead of local N(a)/ARRAY_SIZE(a) definitions, fix some clang warnings.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptAug 20 2015, 5:07 PM

Herald added a subscriber: imp. · View Herald Transcript

I added some people that might be interested. Feel free to add change the reviewers.

eadler removed a subscriber: eadler.Aug 21 2015, 7:37 AM

I'm mostly OK with this change. There was one change in tools/tools/ath/ath_ee_v4k_print/v4k.c (see above), that I don't understand.

Also, in a few files, you added an include for err.h. It's not a big deal, but any particular reason for that?

tools/tools/ath/ath_ee_v4k_print/v4k.c
131 ↗	(On Diff #8090)	Why is this change needed?

Please replace sys/types.h with sys/param.h if the source file already has sys/types.h #include'd in it

tools/tools/ath/ath_ee_v4k_print/v4k.c
131 ↗	(On Diff #8090)	Agreed. This seems unnecessary
tools/tools/crypto/hifnstats.c
28–30 ↗	(On Diff #8090)	Please sort.
tools/tools/mwl/mwlstats/mwlstats.c
37 ↗	(On Diff #8090)	Please sort. Please replace sys/types.h with sys/param.h

Sort includes according to style(9)

In D3442#70971, @rodrigc wrote:

Also, in a few files, you added an include for err.h. It's not a big deal, but any particular reason for that?

I have added it where clang warns about "implicit declaration of function 'err'".

tools/tools/ath/ath_ee_v4k_print/v4k.c
132 ↗	(On Diff #8230)	Size of this array was changed in r220589 (possibly, new fields from this revision should be added instead?)

• rodrigc added inline comments.Aug 29 2015, 6:52 PM

tools/tools/ath/ath_ee_v4k_print/v4k.c
132 ↗	(On Diff #8230)	I'm OK with everything in this patch except for this part. I will commit everything else in this patch. Thanks for submitting! Every other part of this patch is simple, and straightforward, while this is a bit more involved because it involves logic in the code. For this part of the patch, can you submit it as a separate review? It is a bit more involved (slightly) since it involves logic in the code. @adrian can you look at this part of the patch and provide feedback?

Closed by commit rS287297: - Replace N(a)/N(i)/N(T)/LEN(a)/ARRAY_SIZE(a) with nitems() (authored by • rodrigc). · Explain WhyAug 29 2015, 7:47 PM

This revision was automatically updated to reflect the committed changes.

I committed everything in this patch except for the tools/tools/ath/ath_ee_v4k_print/v4k.c print changes.
Need someone who knows the code to comment on that.

avos mentioned this in D4045: tools/tools/ath/ath_ee_v4k_print: reflect rS220589.Oct 30 2015, 11:49 PM