Page MenuHomeFreeBSD
Differential D34075

Fix wording in comments
AcceptedPublic
Actions

Authored by thj on Jan 28 2022, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 12:13 PM
Unknown Object (File)
Jan 1 2024, 4:58 AM
Unknown Object (File)
Nov 14 2023, 9:50 AM
Unknown Object (File)
Nov 11 2023, 6:16 AM
Unknown Object (File)
Oct 10 2023, 5:17 AM
Unknown Object (File)
Feb 17 2023, 2:27 AM
Unknown Object (File)
Feb 13 2023, 9:49 PM
Unknown Object (File)
Jan 10 2023, 12:17 AM
View All 12 Files
Subscribers
0mp
imp
jmg
rew

Details

Reviewers
kevans
allanjude
0mp

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44141
Build 41029: arc lint + arc unit

Event Timeline

thj created this revision.Jan 28 2022, 10:22 AM
Herald added subscribers: jmg, imp. · View Herald TranscriptJan 28 2022, 10:22 AM
thj requested review of this revision.Jan 28 2022, 10:22 AM
Harbormaster completed remote builds in B44137: Diff 102037.Jan 28 2022, 10:22 AM
0mp added a subscriber: 0mp.Jan 28 2022, 10:30 AM
0mp added inline comments.
sys/sys/event.h
196

'did allow' or simply 'allowed'?

thj updated this revision to Diff 102043.Jan 28 2022, 10:50 AM

I didn't read the entire comment, correct english is
"fd did not allow write"
"fd allowed write"

Harbormaster completed remote builds in B44141: Diff 102043.Jan 28 2022, 10:50 AM
0mp accepted this revision.Jan 28 2022, 1:01 PM

LGTM

This revision is now accepted and ready to land.Jan 28 2022, 1:01 PM
allanjude accepted this revision.Jan 28 2022, 2:12 PM

Reviewed by: allanjude

rew added a subscriber: rew.Jan 28 2022, 4:55 PM

You are probably aware, but NOTE_CLOSE_WRITE doesn't mean anything was written...only that the file closed had write access, or simply: fd closed had write access.

What you have is fine, figured I'd mention this though.

Revision Contents
Changeset List

PathSize
sys/
sys/
4 lines

Diff 102043

View Options

sys/sys/event.h

Loading...