Use an unsigned 64-bit integer for exception class.
ClosedPublic
Actions

Authored by jhb on Jan 26 2022, 6:49 PM.

Details

Reviewers

emaste
dim
brooks
imp

Commits

rGe9d6017dea4a: Use an unsigned 64-bit integer for exception class.
rGad1668172107: Use an unsigned 64-bit integer for exception class.
rGb84693501af6: Use an unsigned 64-bit integer for exception class.

Summary

This matches the type in other unwind headers (LLVM libunwind,
libcxxrt, glibc).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44106
Build 40994: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 26 2022, 6:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 26 2022, 6:49 PM

jhb requested review of this revision.Jan 26 2022, 6:49 PM

Harbormaster completed remote builds in B44106: Diff 101953.Jan 26 2022, 6:49 PM

jhb added a child revision: D34050: Use uintptr_t for return type of _Unwind_GetCFA..Jan 26 2022, 6:49 PM

LGTM; for which purposes do we use this header, btw?

This revision is now accepted and ready to land.Jan 26 2022, 8:17 PM

In D34049#769902, @dim wrote:

LGTM; for which purposes do we use this header, btw?

Only for libthr. This is part of my series I had earlier to switching to installing libunwind's unwind.h. This change allows libthr to work with libunwind's unwind.h but does so as a self-contained change before switching which unwind.h is used. Note that include/unwind.h has never been installed, only used by libthr from the source tree.

it might be worth noting in the commit message that include/unwind.h is not installed and is only used for libthr to help clear up some of the confusion

+1 to ed's comments as well.

Closed by commit rGb84693501af6: Use an unsigned 64-bit integer for exception class. (authored by jhb). · Explain WhyJan 27 2022, 6:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb84693501af6: Use an unsigned 64-bit integer for exception class..

dim added a commit: rGad1668172107: Use an unsigned 64-bit integer for exception class..Feb 20 2022, 12:31 PM

dim added a commit: rGe9d6017dea4a: Use an unsigned 64-bit integer for exception class..Feb 20 2022, 5:04 PM