Page MenuHomeFreeBSD

Use an unsigned 64-bit integer for exception class.
ClosedPublic

Authored by jhb on Jan 26 2022, 6:49 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Jan 26 2022, 6:49 PM

LGTM; for which purposes do we use this header, btw?

This revision is now accepted and ready to land.Jan 26 2022, 8:17 PM
In D34049#769902, @dim wrote:

LGTM; for which purposes do we use this header, btw?

Only for libthr. This is part of my series I had earlier to switching to installing libunwind's unwind.h. This change allows libthr to work with libunwind's unwind.h but does so as a self-contained change before switching which unwind.h is used. Note that include/unwind.h has never been installed, only used by libthr from the source tree.

it might be worth noting in the commit message that include/unwind.h is not installed and is only used for libthr to help clear up some of the confusion

+1 to ed's comments as well.