Page MenuHomeFreeBSD
Differential D34043

powerpc: Enable LLDB on all powerpc architectures
ClosedPublic
Actions

Authored by pkubaj on Jan 25 2022, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 1:11 AM
Unknown Object (File)
Feb 24 2025, 12:45 AM
Unknown Object (File)
Feb 22 2025, 8:08 AM
Unknown Object (File)
Jan 13 2025, 3:00 AM
Unknown Object (File)
Dec 21 2024, 4:26 PM
Unknown Object (File)
Nov 25 2024, 11:28 AM
Unknown Object (File)
Nov 24 2024, 8:15 PM
Unknown Object (File)
Oct 28 2024, 11:44 PM
View All 56 Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
jhibbits
alfredo
dim
imp
emaste
Summary

While LLDB on powerpc and powerpcspe builds as-is, on powerpc64 and
powerpc64le it requires adding a couple of additional source files
to build.

Test Plan

make universe
try running lldb on target systems

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44101
Build 40989: arc lint + arc unit

Event Timeline

pkubaj created this revision.Jan 25 2022, 10:50 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJan 25 2022, 10:50 PM
pkubaj requested review of this revision.Jan 25 2022, 10:50 PM
Harbormaster completed remote builds in B44100: Diff 101932.Jan 25 2022, 10:50 PM
pkubaj edited the test plan for this revision. (Show Details)Jan 25 2022, 10:51 PM
pkubaj updated this revision to Diff 101933.Jan 25 2022, 10:56 PM

Remove unrelated change.

Harbormaster completed remote builds in B44101: Diff 101933.Jan 25 2022, 10:56 PM
imp accepted this revision.Jan 25 2022, 11:16 PM

One nit that's more an out loud question than a required change.

share/mk/src.opts.mk
285

so only armv and riscv are broken? Maybe it's time to reverse the sense of this conditional?

This revision is now accepted and ready to land.Jan 25 2022, 11:16 PM
imp added a reviewer: emaste.Jan 25 2022, 11:17 PM
emaste accepted this revision.Jan 25 2022, 11:34 PM
emaste added inline comments.
share/mk/src.opts.mk
285

I suspect that 32-bit arm is fine, so it could probably be just != riscv. In any case though I think we can do it as a separate change.

dim accepted this revision.Jan 26 2022, 7:51 AM

Fine with me.

pkubaj mentioned this in rG0b2d2290fe6d: powerpc: Enable LLDB on all powerpc architectures.Jan 26 2022, 2:05 PM
pkubaj mentioned this in rGcb1bee9bd342: powerpc: Enable LLDB on all powerpc architectures.Feb 8 2022, 12:28 PM
pkubaj closed this revision.Feb 8 2022, 11:28 PM

Revision Contents
Changeset List

PathSize
lib/
clang/
liblldb/
3 lines
share/
mk/
2 lines

Diff 101933

View Options

lib/clang/liblldb/Makefile

TIMESTAMP = 1473715952 TIMESTAMP = 1486633555
SHA256 (postfixadmin-3.0.tar.gz) = 1f07a0003ad2cb2afaecc3d6b0399c3afd38744c43cef504552e687393263392 SHA256 (postfixadmin-3.0.2.tar.gz) = 9a4edb111258c90912aea66ad1dd684445b4f03f08f8549b9d708336ae019c8c
SIZE (postfixadmin-3.0.tar.gz) = 1303883 SIZE (postfixadmin-3.0.2.tar.gz) = 1306500
View Options

share/mk/src.opts.mk

TIMESTAMP = 1473715952 TIMESTAMP = 1486633555
SHA256 (postfixadmin-3.0.tar.gz) = 1f07a0003ad2cb2afaecc3d6b0399c3afd38744c43cef504552e687393263392 SHA256 (postfixadmin-3.0.2.tar.gz) = 9a4edb111258c90912aea66ad1dd684445b4f03f08f8549b9d708336ae019c8c
SIZE (postfixadmin-3.0.tar.gz) = 1303883 SIZE (postfixadmin-3.0.2.tar.gz) = 1306500