Page MenuHomeFreeBSD

powerpc: Enable LLDB on all powerpc architectures
ClosedPublic

Authored by pkubaj on Jan 25 2022, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 4:30 AM
Unknown Object (File)
Feb 19 2024, 5:45 AM
Unknown Object (File)
Jan 30 2024, 2:23 PM
Unknown Object (File)
Jan 10 2024, 1:51 AM
Unknown Object (File)
Dec 20 2023, 5:00 AM
Unknown Object (File)
Oct 19 2023, 8:31 PM
Unknown Object (File)
Sep 22 2023, 5:31 PM
Unknown Object (File)
Sep 22 2023, 5:29 PM

Details

Summary

While LLDB on powerpc and powerpcspe builds as-is, on powerpc64 and
powerpc64le it requires adding a couple of additional source files
to build.

Test Plan

make universe
try running lldb on target systems

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44101
Build 40989: arc lint + arc unit

Event Timeline

One nit that's more an out loud question than a required change.

share/mk/src.opts.mk
285

so only armv and riscv are broken? Maybe it's time to reverse the sense of this conditional?

This revision is now accepted and ready to land.Jan 25 2022, 11:16 PM
emaste added inline comments.
share/mk/src.opts.mk
285

I suspect that 32-bit arm is fine, so it could probably be just != riscv. In any case though I think we can do it as a separate change.