Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
F153983334: D33989.id101979.diff
Sat, Apr 25, 6:21 AM
Unknown Object (File)
Tue, Apr 21, 11:41 AM
Unknown Object (File)
Tue, Apr 21, 6:33 AM
Unknown Object (File)
Tue, Apr 21, 3:54 AM
Unknown Object (File)
Mon, Apr 20, 12:42 PM
Unknown Object (File)
Mon, Apr 20, 12:42 PM
Unknown Object (File)
Tue, Apr 7, 3:26 AM
Unknown Object (File)
Thu, Apr 2, 10:03 AM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable