Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 2:59 PM
Unknown Object (File)
Wed, Feb 5, 6:11 PM
Unknown Object (File)
Wed, Feb 5, 7:56 AM
Unknown Object (File)
Mon, Feb 3, 4:43 PM
Unknown Object (File)
Wed, Jan 29, 6:05 AM
Unknown Object (File)
Wed, Jan 29, 5:49 AM
Unknown Object (File)
Thu, Jan 23, 10:37 AM
Unknown Object (File)
Dec 30 2024, 1:40 AM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable