Switch opt-out STRIP_FBSDID to opt-in EMBED_FBSDID
AcceptedPublic
Actions

Authored by emaste on Dec 21 2021, 6:46 PM.

Details

Reviewers

kib
imp
manu

Summary

With the transition to Git $FreeBSD$ serves no purpose. Stop embedding __FBSDID() by default. Switch to opt-in, in case any downstream consumers have external tooling to populate it.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Dec 21 2021, 6:46 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 21 2021, 6:46 PM

Herald added subscribers: jhibbits, andrew. · View Herald Transcript

emaste requested review of this revision.Dec 21 2021, 6:46 PM

emaste added inline comments.Dec 21 2021, 6:48 PM

lib/csu/Makefile.inc
22	This was added in D33594.
lib/libc/Makefile
24–25	These comments will need to be rewritten but I wanted to see about the approach first.

Correct sense in some comments

I do not see anything wrong with this.

sys/arm64/include/asm.h
33	lint can be dropped as well
sys/sys/cdefs.h
583	BTW, EMBED_FBSDID is in user namespace, perhaps __EMBED_FBSDID is better/must be used.
usr.sbin/lpr/common_source/lp.cdefs.h
89	Remove this at all?

Update comment, move out of user namespace

sys/arm64/include/asm.h
33	Should we drop lint across the tree?
usr.sbin/lpr/common_source/lp.cdefs.h
89	This was introduced in R10:b9ec9b4d77c32527f6c7bb3e10a832edf14835c5 in an attempt to make lpr more portable. I'm not sure how valuable that is, but would rather address it (and lint) separately.