Differential D33594

csu: define STRIP_FBSDID
ClosedPublic
Actions

Authored by emaste on Dec 20 2021, 9:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 8 2024, 7:32 AM

	Unknown Object (File)
	Mar 8 2024, 7:32 AM

	Unknown Object (File)
	Mar 8 2024, 7:32 AM

	Unknown Object (File)
	Mar 8 2024, 7:20 AM

	Unknown Object (File)
	Jan 13 2024, 5:53 PM

	Unknown Object (File)
	Dec 20 2023, 4:56 AM

	Unknown Object (File)
	Dec 15 2023, 2:39 PM

	Unknown Object (File)
	Dec 15 2023, 9:22 AM

View All 20 Files

Subscribers

freebsd-toolchain-list

Details

Reviewers: None
Commits: rGef9fc5c52c4a: csu: define STRIP_FBSDID
rGcb2d1350154a: csu: define STRIP_FBSDID

Summary

__FBSDID() places the provided string in the output object's .comment section. However, with the transition to Git $FreeBSD$ is no longer expanded and so we emitted a literal $FreeBSD$.

$FreeBSD$ will be addressed in a holistic manner in the future, but for now define STRIP_FBSDID to at least avoid having it embedded into everything linked on FreeBSD (via csu).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 20 2021, 9:38 PM

emaste created this revision.

Why not define STRIP_FBSDID globally, reusing the same argument?

This revision was not accepted when it landed; it landed in state Needs Review.Dec 21 2021, 6:35 PM

Closed by commit rGcb2d1350154a: csu: define STRIP_FBSDID (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGcb2d1350154a: csu: define STRIP_FBSDID.

Herald added a subscriber: imp. · View Herald TranscriptDec 21 2021, 6:35 PM

Why not define STRIP_FBSDID globally, reusing the same argument?

Yes, although perhaps change the sense and make it EMBED_FBSDID instead?

Oops, I did not intend to push this to main yet. I will open another review for an alternate approach.

emaste mentioned this in D33604: Switch opt-out STRIP_FBSDID to opt-in EMBED_FBSDID.Dec 21 2021, 6:48 PM

emaste added a commit: rGef9fc5c52c4a: csu: define STRIP_FBSDID.Feb 8 2022, 9:46 PM

Revision Contents
Changeset List

Path

Size

lib/

csu/

1 line

Diff 100426

lib/csu/Makefile.inc

Loading...