Page MenuHomeFreeBSD

Convert bsdinstall/distextract for libbsddialog
ClosedPublic

Authored by asiciliano on Dec 20 2021, 2:46 AM.
Tags
None
Referenced Files
F81518999: D33581.diff
Wed, Apr 17, 11:17 AM
Unknown Object (File)
Feb 8 2024, 9:13 PM
Unknown Object (File)
Dec 23 2023, 3:48 AM
Unknown Object (File)
Dec 20 2023, 4:55 AM
Unknown Object (File)
Dec 10 2023, 7:06 PM
Unknown Object (File)
Nov 28 2023, 2:55 AM
Unknown Object (File)
Oct 8 2023, 12:37 PM
Unknown Object (File)
Sep 19 2023, 7:17 AM
Subscribers

Details

Summary

Convert bsdinstall/distextract for libbsddialog.

This review depends on libbsddialog 0.0.2 https://reviews.freebsd.org/D33580

Test Plan

Download some txz from distfetch https://reviews.freebsd.org/D33425
then:

env DISTRIBUTIONS="kernel.txz tests.txz" BSDINSTALL_CHROOT="./extractdir" BSDINSTALL_DISTDIR="/home/test" ./distextract
`

┌────────Archive Extraction────────┐                      
│ kernel.txz       [    Done     ] │                      
│ tests.txz        [    Done     ] │                      
│                                  │                      
│ Extracting distribution files... │                      
│                                  │                      
│  ┌─Overall Progress───────────┐  │                      
│  │            100%            │  │                      
│  └────────────────────────────┘  │                      
└──────────────────────────────────┘

`
ls extractdir/boot/kernel/
... kmods and company ...

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 21 2021, 3:14 PM
usr.sbin/bsdinstall/distextract/Makefile
5–6

HAVE_BSDDIALOG is not necessary here, why adding it?

usr.sbin/bsdinstall/distextract/Makefile
5–6

Ops sorry, of course it is an error (I opened the tzseup Makefile instead of the distfetch Makefile).
Should I update the review or can you fix before to commit?

asiciliano marked an inline comment as not done.

Update review to fix Makefile:

  • delete -DHAVE_BSDDIALOG
This revision now requires review to proceed.Dec 26 2021, 6:52 AM

Address Revision Feedback: fix Makefile

usr.sbin/bsdinstall/distextract/Makefile
5–6

Makefile fixed

This revision was not accepted when it landed; it landed in state Needs Review.Jan 1 2022, 8:53 PM
This revision was automatically updated to reflect the committed changes.

pushed with modification for it to build properly in base (warning about const char * vs char *