Always print a stack when in the kernel debugger
AcceptedPublic
Actions

Authored by andrew on Dec 15 2021, 4:18 PM.

Details

Reviewers

jhb
markj
manu
imp

Group Reviewers

arm64

Summary

When in the kernel debugger it's useful to print the stack even if it
isn't within the expected stack memory. This can happen early in the
boot when the thread stack memory has't been set.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43379
Build 40267: arc lint + arc unit

Event Timeline

andrew created this revision.Dec 15 2021, 4:18 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 15 2021, 4:18 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Dec 15 2021, 4:18 PM

Harbormaster completed remote builds in B43379: Diff 100081.Dec 15 2021, 4:18 PM

LGTM

imp accepted this revision.Dec 15 2021, 5:38 PM

This revision is now accepted and ready to land.Dec 15 2021, 5:38 PM

I think this won't work in CHERI? Another approach might be to recognize the early boot case in unwind_frame() and skip the kstack_contains check if you are on the early stack (e.g. !cold) instead which would be smaller (don't have to add the bool and change all the callers)