Fix dtrace fbt return probes on arm64
ClosedPublic
Actions

Authored by andrew on Dec 14 2021, 4:05 PM.

Details

Reviewers

kp
markj
gnn

Group Reviewers

arm64

Commits

rG5143c53dfb28: Fix dtrace fbt return probes on arm64
rGe3ccf4f9dee9: Fix dtrace fbt return probes on arm64

Summary

As with arm and riscv fix return fbt probes on arm64. arg0 should be
the offset within the function of the return instruction and arg1
should be the return value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Dec 14 2021, 4:05 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2021, 4:05 PM

andrew requested review of this revision.Dec 14 2021, 4:05 PM

Harbormaster completed remote builds in B43343: Diff 100002.Dec 14 2021, 4:05 PM

markj accepted this revision.Dec 14 2021, 4:09 PM

This revision is now accepted and ready to land.Dec 14 2021, 4:09 PM

Not tested, but that looks correct. It's basically the same fix that was done for riscv.

Closed by commit rGe3ccf4f9dee9: Fix dtrace fbt return probes on arm64 (authored by andrew). · Explain WhyDec 14 2021, 4:34 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGe3ccf4f9dee9: Fix dtrace fbt return probes on arm64.

Herald added a reviewer: gnn. · View Herald TranscriptDec 14 2021, 4:34 PM

andrew added a commit: rG5143c53dfb28: Fix dtrace fbt return probes on arm64.Dec 29 2021, 10:41 AM

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

dtrace/

aarch64/

dtrace_subr.c

2 lines

fbt/

aarch64/

fbt_isa.c

16 lines

Diff 100004

View Options

sys/cddl/dev/dtrace/aarch64/dtrace_subr.c