Differential D33368

rack: drop connection synchronously, when we can
ClosedPublic
Actions

Authored by glebius on Dec 10 2021, 2:47 AM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG66aeb0b53b39: rack: drop connection synchronously, when we can

Summary

For all functions that are leaves of tcp_input() call
ctf_do_dropwithreset_conn() instead of ctf_do_dropwithreset(), cause
we always got tp and we want it to be dropped.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43274
Build 40162: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 10 2021, 2:47 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 10 2021, 2:47 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 10 2021, 2:47 AM

Harbormaster completed remote builds in B43274: Diff 99809.Dec 10 2021, 2:47 AM

glebius added a parent revision: D33367: bbr: drop packet synchronously in ctf_do_dropwithreset_conn().Dec 10 2021, 2:47 AM

glebius added a child revision: D33369: rack: rack_do_compressed_ack_processing() can call tcp_drop().

You might want to check what rrs@ thinks...

This revision is now accepted and ready to land.Dec 10 2021, 12:04 PM

Rebase, update descr.

This revision now requires review to proceed.Dec 13 2021, 6:14 PM

Harbormaster completed remote builds in B43317: Diff 99950.Dec 13 2021, 6:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2021, 4:50 PM

Closed by commit rG66aeb0b53b39: rack: drop connection synchronously, when we can (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG66aeb0b53b39: rack: drop connection synchronously, when we can.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

18 lines

Diff 99809

View Options

sys/netinet/tcp_stacks/rack.c

rack: drop connection synchronously, when we canClosedPublicActions