mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common.
ClosedPublic
Actions

Authored by jhb on Dec 8 2021, 9:51 PM.

Details

Reviewers

emaste
jrtc27
kib

Commits

rGb602867013cf: mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common.
rG23e0c0e9a3e0: mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common.

Summary

Previously TLS_DTV_OFFSET was added to the offset passed to
tls_get_addr_common; however, this approach matches powerpc and RISC-V
and better matches the intention.

Sponsored by: The University of Cambridge, Google Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43247
Build 40135: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 8 2021, 9:51 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptDec 8 2021, 9:51 PM

jhb requested review of this revision.Dec 8 2021, 9:51 PM

Harbormaster completed remote builds in B43247: Diff 99735.Dec 8 2021, 9:51 PM

jhb added a parent revision: D33346: mips: Rename TLS_DTP_OFFSET to TLS_DTV_OFFSET..Dec 8 2021, 9:51 PM

jhb added a child revision: D33348: mips _libc_get_static_tls_base: Narrow scope of #ifdef..

kib accepted this revision.Dec 8 2021, 11:07 PM

This revision is now accepted and ready to land.Dec 8 2021, 11:07 PM

Closed by commit rG23e0c0e9a3e0: mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common. (authored by jhb). · Explain WhyDec 9 2021, 9:25 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG23e0c0e9a3e0: mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common..

jhb added a commit: rGb602867013cf: mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common..Apr 29 2022, 8:56 PM

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

mips/

reloc.c

5 lines

Diff 99735

View Options

libexec/rtld-elf/mips/reloc.c

mips: Add TLS_DTV_OFFSET to the result of tls_get_addr_common.ClosedPublicActions