crypto: Don't assert for empty output buffers.
ClosedPublic
Actions

Authored by jhb on Nov 30 2021, 5:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 29, 12:34 AM

	Unknown Object (File)
	Sun, Nov 23, 9:15 PM

	Unknown Object (File)
	Sat, Nov 22, 4:09 AM

	Unknown Object (File)
	Nov 8 2025, 7:34 AM

	Unknown Object (File)
	Oct 25 2025, 8:42 PM

	Unknown Object (File)
	Oct 15 2025, 3:51 AM

	Unknown Object (File)
	Oct 15 2025, 3:51 AM

	Unknown Object (File)
	Oct 15 2025, 3:51 AM

Subscribers

Details

Reviewers

markj

Commits

rGaf2c2a9cb59d: crypto: Don't assert for empty output buffers.
rGec498562b71a: crypto: Don't assert for empty output buffers.

Summary

It is always valid for crp_payload_output_start to be 0. However, if
an output buffer is empty (e.g. a decryption request with a tag but an
empty payload), the existing assertion failed since 0 is not less than
0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 30 2021, 5:16 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptNov 30 2021, 5:16 PM

jhb requested review of this revision.Nov 30 2021, 5:16 PM

Harbormaster completed remote builds in B43057: Diff 99246.Nov 30 2021, 5:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 8:18 PM

Closed by commit rGec498562b71a: crypto: Don't assert for empty output buffers. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGec498562b71a: crypto: Don't assert for empty output buffers..

jhb added a commit: rGaf2c2a9cb59d: crypto: Don't assert for empty output buffers..Apr 29 2022, 8:55 PM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

crypto.c

3 lines

Diff 99776

View Options

crypto: Don't assert for empty output buffers.ClosedPublicActions