mac address does not update when removing the primary iface from a lagg

[shahark_mellanox.com]

Summary

see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201916

Test Plan

1. ifconfig lagg0 create laggport ifp0 laggport ifp1
2. ifconfig lagg0 -laggport ifp0

and look at the macs before and after

[markb_mellanox.com]

Is there any update on this issue?

[j-nitrology.com]

This tests well and resolves the proposed issue for me on head.

[sbruno]

I'm fine with this and can commit it. If there's no further comment I'll commit tonight.

[hrs]

I do not think this fix is correct. lagg_port_destroy() should enqueue an lladdr change into sc_lladdr_task when the primary port is removed. Removing the llq_primary == 0 condition causes an unnecessary lladdr update on the primary interface.

Can someone test the following patch?

http://people.allbsd.org/~hrs/FreeBSD/if_lagg.c.20151005-1.diff

[shahark_mellanox.com]

I've tested the patch and it works

[hrs]

In D3301#78885, @shahark_mellanox.com wrote:

I've tested the patch and it works

Thank you. I will commit it if nobody objects to it in 24 hours.