Page MenuHomeFreeBSD

mac address does not update when removing the primary iface from a lagg
ClosedPublic

Authored by shahark_mellanox.com on Aug 4 2015, 11:18 AM.

Details

Summary
Test Plan
  1. ifconfig lagg0 create laggport ifp0 laggport ifp1
  2. ifconfig lagg0 -laggport ifp0

and look at the macs before and after

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

shahark_mellanox.com retitled this revision from to mac address does not update when removing the primary iface from a lagg .
shahark_mellanox.com updated this object.
shahark_mellanox.com edited the test plan for this revision. (Show Details)
shahark_mellanox.com added a reviewer: hiren.
shahark_mellanox.com set the repository for this revision to rS FreeBSD src repository - subversion.
shahark_mellanox.com added a project: network.

This tests well and resolves the proposed issue for me on head.

I'm fine with this and can commit it. If there's no further comment I'll commit tonight.

hrs requested changes to this revision.Oct 5 2015, 2:19 AM
hrs added a reviewer: hrs.
hrs added a subscriber: hrs.

I do not think this fix is correct. lagg_port_destroy() should enqueue an lladdr change into sc_lladdr_task when the primary port is removed. Removing the llq_primary == 0 condition causes an unnecessary lladdr update on the primary interface.

Can someone test the following patch?

http://people.allbsd.org/~hrs/FreeBSD/if_lagg.c.20151005-1.diff

This revision now requires changes to proceed.Oct 5 2015, 2:19 AM

I've tested the patch and it works

Thank you. I will commit it if nobody objects to it in 24 hours.

This revision was automatically updated to reflect the committed changes.