Page MenuHomeFreeBSD

loader: lsefi: Print more information
ClosedPublic

Authored by manu on Nov 15 2021, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 6:01 PM
Unknown Object (File)
Thu, Mar 14, 12:36 AM
Unknown Object (File)
Feb 19 2024, 2:20 AM
Unknown Object (File)
Feb 16 2024, 8:00 PM
Unknown Object (File)
Feb 11 2024, 8:30 PM
Unknown Object (File)
Feb 8 2024, 1:26 PM
Unknown Object (File)
Dec 24 2023, 4:48 PM
Unknown Object (File)
Dec 20 2023, 1:34 AM
Subscribers

Details

Summary

Printing the EFI_HANDLE pointer isn't very useful.
If the handle have a IMAGE_DEVICE_PATH or a DEVICE_PATH protocol print it.
This makes it easier to see which devices are present and what protocol they
expose.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Test Plan

Tested on u-boot based and edk2 based firmware

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Nov 15 2021, 12:58 PM

It's better than what we have as is... Question about whether or not we have multiple paths that would be useful or not (I can't recall that deatil). If so, please adjust to print both (I still approve), if not just indicate in comments (and I also still approve)

stand/efi/loader/main.c
1417

Can you have both an image path and a devpath for the handle? And would you want to print them both?

This revision is now accepted and ready to land.Nov 15 2021, 3:41 PM
stand/efi/loader/main.c
1417

You can't if I understand correctly the UEFI driver model.

stand/efi/loader/main.c
1417

OK then. forget I said anything... I wasn't quite sure... feel free to commit when you think the review is complete.

This revision was automatically updated to reflect the committed changes.