Page MenuHomeFreeBSD

if_gif: fix vnet shutdown panic
ClosedPublic

Authored by kp on Nov 4 2021, 5:17 PM.
Tags
None
Referenced Files
F137857482: D32835.id98025.diff
Wed, Nov 26, 12:32 PM
Unknown Object (File)
Tue, Nov 25, 7:07 AM
Unknown Object (File)
Tue, Nov 25, 2:44 AM
Unknown Object (File)
Sat, Nov 15, 1:18 PM
Unknown Object (File)
Wed, Nov 5, 2:11 AM
Unknown Object (File)
Thu, Oct 30, 11:14 PM
Unknown Object (File)
Oct 11 2025, 9:58 AM
Unknown Object (File)
Oct 11 2025, 9:38 AM

Details

Summary

If an if_gif exists and has an address assigned inside a vnet when the
vnet is shut down we failed to clean up the address, leading to a panic
when we ip_destroy() and the V_in_ifaddrhashtbl is not empty.

This happens because of the VNET_SYS(UN)INIT order, which means we
destroy the if_gif interface before the addresses can be purged (and
if_detach() does not remove addresses, it assumes this will be done by
the stack teardown code).

Set subsystem SI_SUB_PSEUDO just like if_bridge so the cleanup
operations happen in the correct order.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable