Page MenuHomeFreeBSD

Remove useless version wildcard from CONFLICTS entries
ClosedPublic

Authored by se on Oct 28 2021, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 21 2024, 8:56 AM
Unknown Object (File)
Jan 12 2024, 3:46 AM
Unknown Object (File)
Dec 24 2023, 2:15 AM
Unknown Object (File)
Dec 20 2023, 2:22 AM
Unknown Object (File)
Sep 9 2023, 1:18 AM
Unknown Object (File)
Jul 16 2023, 10:21 AM
Unknown Object (File)
Mar 3 2023, 10:38 AM
Unknown Object (File)
Feb 18 2023, 4:44 AM
Subscribers

Details

Reviewers
bapt
Group Reviewers
portmgr
Summary

The matching for conflicts performs a file glob style match of the patterns first with the package name without version (i.e. as reported by "pkg query "%n") and then against the full package name ("%n-%v").

It has been common practice to use patterns like "bash-[0-9]*" to match all versions of bash packages, for example, and to not match bash-completions, as "bash-*" would do.
But a pattern of just "bash" will have exactly the same effect as "bash-[0-9]*" due to the way, the check has been implemented.

This review contains patches for all ports that have CONFLICTS entries redundantly ending in "-[0-9]*" and removes that version wildcard.

If portmgr agrees, these CONFLICTS could be simplified in one go.
Else I could generate (hundreds) of reviews for the individual port committers to approve.

Since this patch is against the ports tree as of 2021-10-28 13:00:00 UTC and so many ports are affected, it might become partially stale within a few days or weeks.
I'm of course willing to rebase the patch as requireed, if I get approval to commit these changes.

Test Plan

Apply patches and verify that they still lead to identical conflicts check results.
This has been done on a subset of the affected ports after generating the patch with the expected (correct) outcome.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

se requested review of this revision.Oct 28 2021, 1:08 PM
se created this revision.
bapt added a subscriber: bapt.

You don't need portmgr validation for that this is part of the cleanup blanket ;)

This revision is now accepted and ready to land.Oct 28 2021, 1:58 PM