Page MenuHomeFreeBSD
Differential D32691

GIC: add IRQ ranges
AcceptedPublic
Actions

Authored by br on Oct 27 2021, 10:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 25 2024, 4:27 AM
Unknown Object (File)
Jan 14 2024, 9:06 AM
Unknown Object (File)
Dec 20 2023, 3:28 AM
Unknown Object (File)
Nov 24 2023, 1:44 AM
Unknown Object (File)
Nov 24 2023, 12:17 AM
Unknown Object (File)
Jul 9 2023, 10:47 PM
Unknown Object (File)
Jul 6 2023, 9:00 PM
Unknown Object (File)
Jun 25 2023, 5:45 AM
View All 13 Files
Subscribers
andrew
emaste
mhorne

Details

Reviewers
jrtc27
manu
mhorne
Group Reviewers
arm64
Summary

Based on GIC architecture version 3 and version 4 spec.
This is needed for PMU ACPI driver

Test Plan

Tested on N1SDP

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Oct 27 2021, 10:42 AM
Herald added a reviewer: manu. · View Herald TranscriptOct 27 2021, 10:42 AM
Herald added subscribers: emaste, andrew. · View Herald Transcript
br requested review of this revision.Oct 27 2021, 10:42 AM
br added a child revision: D24423: arm/pmu: add ACPI attachment.
br edited the test plan for this revision. (Show Details)Oct 27 2021, 10:52 AM
br removed a child revision: D24423: arm/pmu: add ACPI attachment.Oct 27 2021, 11:41 AM
br updated this revision to Diff 97541.Oct 27 2021, 12:18 PM

Restore MAX_RLEN change

br updated this revision to Diff 97542.Oct 27 2021, 12:18 PM

Restore diff

mhorne added a subscriber: mhorne.Oct 27 2021, 3:35 PM
mhorne added inline comments.
sys/arm64/arm64/gic_v3_reg.h
46–50

Did you forget to add some changes to gic_v3.c? You can't just remove these definitions outright.

br added inline comments.Nov 5 2021, 5:43 PM
sys/arm64/arm64/gic_v3_reg.h
46–50

I moved them to gic_common.h so they are in the same place.
gic_v3.c includes gic_common.h header as I remember.

mhorne accepted this revision.Nov 22 2021, 8:07 PM

I guess this is no longer required, but looks good regardless.

sys/arm64/arm64/gic_v3_reg.h
46–50

Oh, duh. You are right.

This revision is now accepted and ready to land.Nov 22 2021, 8:07 PM
andrew added inline comments.Nov 22 2021, 9:48 PM
sys/arm/arm/gic_common.h
59–65

The EPPI, ESPI, and LPI values should be in gic_v3_reg.h as they are GICv3/4 specific.

67–70

Is this still useful? It should only be needed within a GIC driver so could be defined there when it's used.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
19 lines
arm64/
arm64/
5 lines

Diff 97542

View Options

sys/arm/arm/gic_common.h

Loading...
View Options

sys/arm64/arm64/gic_v3_reg.h

Loading...