This key is Declarative and should always be sent even if the
initiator did not send it's own limit. This is similar to the fix in
fc79cf4fea72 but for the target side.
Sponsored by: Chelsio Communications
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
PR: 259439
As @mav points out this one is not a functional bug, it just means if the initiator doesn't send MaxRecvDataSegmentLength then send and receive will both just remain at default. It seems logical and simple to me to just send all Declarative keys, but I have no idea if there are some strange initiators that would behave poorly.
Comment Actions
I do think it's a bug in that the spec says there is no negotiation for declarative keys, instead that the proposing party just declares them (section 6 in RFC 7143). Just because an initiator doesn't support a large receive buffer doesn't mean it can't stream out larger PDUs on send. Sending large PDUs is easier than receiving large PDUs.