Page MenuHomeFreeBSD

LinuxKPI: pci.h / linux_pci.c rename pci_driver field
ClosedPublic

Authored by bz on Oct 25 2021, 5:20 PM.
Tags
None
Referenced Files
F132657460: D32645.diff
Sat, Oct 18, 7:54 PM
F132579822: D32645.id97412.diff
Sat, Oct 18, 3:38 AM
Unknown Object (File)
Mon, Oct 13, 9:06 AM
Unknown Object (File)
Mon, Oct 13, 9:06 AM
Unknown Object (File)
Mon, Oct 13, 9:06 AM
Unknown Object (File)
Sun, Oct 12, 8:40 PM
Unknown Object (File)
Sun, Oct 12, 7:05 AM
Unknown Object (File)
Thu, Oct 9, 4:43 AM

Details

Summary

Rename the struct pci_driver {} field got the list_head from links
to node as a driver is actually initialsing this to {} which seems
questionable but it will at least make us match the Linux structure
field name.

According to my investigations this field is not used anywhere outside
our implementation so I consider this MFC-able.

MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42349
Build 39237: arc lint + arc unit

Event Timeline

bz requested review of this revision.Oct 25 2021, 5:20 PM

I cannot find a "graphics" or "drm" review group; do we have one? The main concern here is not to break drm binary drivers shipped in binary packages when MFCing.

This revision is now accepted and ready to land.Oct 25 2021, 5:30 PM
manu added a subscriber: manu.

We do not seems to use this in drm.

In D32645#736890, @manu wrote:

We do not seems to use this in drm.

Thanks a lot for confirming so quickly.